Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_variant_default_code #341

Open
wants to merge 73 commits into
base: 17.0
Choose a base branch
from

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Apr 8, 2024

No description provided.

alfredo and others added 30 commits April 8, 2024 15:06
…der_default_code

Separate the default code assignment in 2 steps, one obtains the
code and the other set this value on product.
Now is easier to extend this method.
* IMP dependency, field name, complete view

* FIX move sale.settings to base settings

* IMP reference mask use untranslate attribute names

* FIX some tests with @chienandalu remarks
* [IMP] Improve French (fr) translation
* [FIX] Fixed bad display of config. settings
* [FIX] Display product attribute value code when open the product attribute form view from product form view
Currently translated at 63.6% (14 of 22 strings)

Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/hr/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/pt/
missing the possibility to edit of attribute code in form view (and also tree view)
It was present in tree view, but not in form view, and now the tree
is not editable.
When a variant is created, the mask is evaluated expecting the main
language term, so we should avoid taking the translated value when we
are in another language.
@astirpe astirpe force-pushed the 17_mig_product_variant_default_code branch from db037d8 to 88b0bfe Compare April 8, 2024 13:19
@astirpe astirpe marked this pull request as ready for review April 8, 2024 13:21
@astirpe astirpe mentioned this pull request Apr 8, 2024
6 tasks
@HaraldPanten
Copy link

/ocabot migration product_variant_default_code

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 11, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
Copy link

@PieterPaulussen PieterPaulussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code of this module seems rather old and undocumented. There are also some view and file namings that can be refactored to re-align them with the Odoo coding conventions.
Going to test the module in a migration setup and provide feedback.

LGTM functionally

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@Crazor
Copy link

Crazor commented Oct 7, 2024

I tried the code from this PR, and I'm missing the input field for the Reference Prefix and the automask checkbox.

@giarve
Copy link
Contributor

giarve commented Nov 25, 2024

Should also take into account this: #372

@astirpe astirpe force-pushed the 17_mig_product_variant_default_code branch from 06c50eb to 71cc5c3 Compare December 6, 2024 17:04
@astirpe
Copy link
Member Author

astirpe commented Dec 6, 2024

@giarve done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.