[17.0][MIG] product_variant_default_code #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der_default_code Separate the default code assignment in 2 steps, one obtains the code and the other set this value on product. Now is easier to extend this method.
* IMP dependency, field name, complete view * FIX move sale.settings to base settings * IMP reference mask use untranslate attribute names * FIX some tests with @chienandalu remarks
* [IMP] Improve French (fr) translation * [FIX] Fixed bad display of config. settings * [FIX] Display product attribute value code when open the product attribute form view from product form view
As needed in v11
Currently translated at 63.6% (14 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/hr/
…ept multiple recordset
Currently translated at 100.0% (22 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/pt/
missing the possibility to edit of attribute code in form view (and also tree view)
It was present in tree view, but not in form view, and now the tree is not editable.
When a variant is created, the mask is evaluated expecting the main language term, so we should avoid taking the translated value when we are in another language.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-variant-16.0/product-variant-16.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_default_code/
…e_ids" This reverts commit 20320aa.
When a product is being created or edited and attributes have not yet been added, a message is printed out in the band in case the reference prefix has not been filled in. If there is no error, this strip should remain hidden. TT42976
astirpe
force-pushed
the
17_mig_product_variant_default_code
branch
from
db037d8 to
88b0bfe
Compare
|
/ocabot migration product_variant_default_code |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
PieterPaulussen
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
The code of this module seems rather old and undocumented. There are also some view and file namings that can be refactored to re-align them with the Odoo coding conventions.
Going to test the module in a migration setup and provide feedback.
LGTM functionally
github-actions
bot
removed
the
stale
|
I tried the code from this PR, and I'm missing the input field for the Reference Prefix and the automask checkbox. |
|
Should also take into account this: #372 |
astirpe
force-pushed
the
17_mig_product_variant_default_code
branch
from
06c50eb to
71cc5c3
Compare
|
@giarve done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.