-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_variant_default_code #341
base: 17.0
Are you sure you want to change the base?
Conversation
…der_default_code Separate the default code assignment in 2 steps, one obtains the code and the other set this value on product. Now is easier to extend this method.
* IMP dependency, field name, complete view * FIX move sale.settings to base settings * IMP reference mask use untranslate attribute names * FIX some tests with @chienandalu remarks
* [IMP] Improve French (fr) translation * [FIX] Fixed bad display of config. settings * [FIX] Display product attribute value code when open the product attribute form view from product form view
As needed in v11
Currently translated at 63.6% (14 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/hr/
…ept multiple recordset
Currently translated at 100.0% (22 of 22 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/pt/
missing the possibility to edit of attribute code in form view (and also tree view)
It was present in tree view, but not in form view, and now the tree is not editable.
When a variant is created, the mask is evaluated expecting the main language term, so we should avoid taking the translated value when we are in another language.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-variant-16.0/product-variant-16.0-product_variant_default_code Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_default_code/
…e_ids" This reverts commit 20320aa.
When a product is being created or edited and attributes have not yet been added, a message is printed out in the band in case the reference prefix has not been filled in. If there is no error, this strip should remain hidden. TT42976
db037d8
to
88b0bfe
Compare
/ocabot migration product_variant_default_code |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code of this module seems rather old and undocumented. There are also some view and file namings that can be refactored to re-align them with the Odoo coding conventions.
Going to test the module in a migration setup and provide feedback.
LGTM functionally
I tried the code from this PR, and I'm missing the input field for the Reference Prefix and the automask checkbox. |
Should also take into account this: #372 |
06c50eb
to
71cc5c3
Compare
@giarve done, thanks! |
No description provided.